Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource-arn not working with SQS when ran with another resource #6346

Open
ThomasNicholson-ho opened this issue Jan 2, 2025 · 1 comment · May be fixed by #6352
Open

Resource-arn not working with SQS when ran with another resource #6346

ThomasNicholson-ho opened this issue Jan 2, 2025 · 1 comment · May be fixed by #6352
Labels
bug status/needs-triage Issue pending triage

Comments

@ThomasNicholson-ho
Copy link

Steps to Reproduce

  1. aws --resource-arn arn:aws:s3:::example.bucket arn:aws:sqs:eu-west-1:000000000000:queue-name
  2. AWS
  3. Single Account

Expected behavior

A list of checks containing both S3 and SQS checks.

Actual Result with Screenshots or Logs

checks_to_execute only has S3 checks and SQS is removed.

{'s3_bucket_object_lock', 's3_bucket_public_list_acl', 's3_bucket_event_notifications_enabled', 's3_bucket_kms_encryption', 's3_bucket_object_versioning', 's3_bucket_acl_prohibited', 's3_bucket_secure_transport_policy', 's3_bucket_cross_account_access', 's3_bucket_no_mfa_delete', 's3_account_level_public_access_blocks', 's3_bucket_server_access_logging_enabled', 's3_bucket_public_write_acl', 's3_bucket_default_encryption', 's3_bucket_lifecycle_enabled', 's3_bucket_level_public_access_block', 's3_multi_region_access_point_public_access_block', 's3_bucket_public_access', 's3_access_point_public_access_block', 's3_bucket_policy_public_write_access', 's3_bucket_cross_region_replication'}

How did you install Prowler?

From pip package (pip install prowler)

Environment Resource

Workstation

OS used

Ubuntu

Prowler version

Prowler 5.0.5

Pip version

pip 24.3.1

Context

I believe SQS needs adding to services_without_subservices (https://github.com/prowler-cloud/prowler/blob/master/prowler/providers/aws/aws_provider.py#L792)

@puchy22 puchy22 linked a pull request Jan 3, 2025 that will close this issue
3 tasks
@puchy22
Copy link
Member

puchy22 commented Jan 3, 2025

Hi @ThomasNicholson-ho, you are correct that SQS is missing from the services_without_subservices list. I believe the issue arises because it needs to be added automatically and not with an static list. I'll take note of this, as it may be failing for other services that are not included in the list.

I've created a PR (#6352) to address this issue. Please let me know if it resolves the problem for you.

Thanks for pointing this out and for using Prowler 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug status/needs-triage Issue pending triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants