Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(internal/request): add missing impersonate groups for serviceaccounts #350

Merged
merged 1 commit into from
Dec 6, 2023
Merged

fix(internal/request): add missing impersonate groups for serviceaccounts #350

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions internal/request/http.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import (

authenticationv1 "k8s.io/api/authentication/v1"
authorizationv1 "k8s.io/api/authorization/v1"
"k8s.io/apiserver/pkg/authentication/serviceaccount"
"sigs.k8s.io/controller-runtime/pkg/client"
)

Expand Down Expand Up @@ -97,6 +98,15 @@ func (h http) GetUserAndGroups() (username string, groups []string, err error) {
defer func() {
username = impersonateUser
groups = nil

// If the user is of a service account, replicate the work of the built-in service account token authenticator
// by appending the expected service account groups:
// - system:serviceaccounts:<namespace>
// - system:serviceaccounts
if namespace, _, err := serviceaccount.SplitUsername(username); err == nil {
groups = append(groups, serviceaccount.AllServiceAccountsGroup)
groups = append(groups, fmt.Sprintf("%s%s", serviceaccount.ServiceAccountGroupPrefix, namespace))
}
}()
}

Expand Down
Loading