fix(internal/request): add missing impersonate groups for serviceaccounts #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxgio92
changed the title
…unts When clients request to impersonate user, the group impersonation should be done only when also clients request explicitely to impersonate group. Nevertheless, an excpetion should be considered for service accounts. With service account built-in authenticator, requests made with service account token are authenticated as: - user name: system:serviceaccount:<namespace>:<serviceaccount_name> - groups: - system:serviceaccounts - system:serviceaccounts:<namespace> - system:authenticated (included for all authenticated users) This patch considers the case of service accounts adding the mentioned groups to the list of impersonate groups, when requests try to impersonate a service account's user. More details in the official documentation about service account authenticator [1] and user impersonation [2]. 1. https://kubernetes.io/docs/reference/access-authn-authz/authentication/#service-account-tokens 2. https://kubernetes.io/docs/reference/access-authn-authz/authentication/#user-impersonation Signed-off-by: Massimiliano Giovagnoli <[email protected]> Co-authored-by: Dario Tranchitella <[email protected]>
|
JFI @prometherion I've made a change as the block was on the wrong path (in the impersonate group condition, which in this specific case was never taken. I've moved it inside the impersonate user condition block. |
maxgio92
changed the title
maxgio92
changed the title
oliverbaehler
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This PR adds missing impersonate groups for
ServiceAccounts.Context
When clients request to impersonate user, the group impersonation should be done only when also clients request explicitely to impersonate group.
The problem
Nevertheless, an exception should be considered for service accounts.
With service account built-in authenticator, requests made with service account token are authenticated as:
system:serviceaccount:<namespace>:<serviceaccount_name>system:serviceaccountssystem:serviceaccounts:<namespace>system:authenticated(included for all authenticated users)The solution
This patch considers the case of service accounts adding the mentioned groups to the list of impersonate groups, when requests try to impersonate a service account's user.
Related issue
Fixes #349
Additional info
More details in the official documentation about service account authenticator [1] and user impersonation [2].