-
Notifications
You must be signed in to change notification settings - Fork 6
fix: collector port availability check in collector_test.sh #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xadahiya
previously approved these changes
Sep 12, 2025
Contributor
xadahiya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…pace in collector_test even if port does not match
…ced env" This reverts commit 2492281.
xadahiya
approved these changes
Sep 17, 2025
Contributor
xadahiya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
SwaroopH
approved these changes
Sep 17, 2025
Member
SwaroopH
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #152
Checklist
Current behaviour
The
collector_test.shscript unconditionally searches for available ports and overwrites theLOCAL_COLLECTOR_PORTin the environment file whenever no active collector is found, regardless of whether the configured port is actually in use. This causes the script to ignore explicitly configured port values and replace them with the first available port in the range (50051-51050), even when the configured port is perfectly available.New expected behaviour
The script now respects explicitly configured
LOCAL_COLLECTOR_PORTvalues and only searches for alternative ports when there is an actual port conflict. When the configured port is available, it uses that port without modifying the environment file. Port replacement only occurs when the configured port is genuinely in use by another service.Change logs
Fixed
LOCAL_COLLECTOR_PORTvaluestest_pingresults from initial connectivity testDeployment Instructions
dockerifybranch of the lite node and confirm whether the free local collector port as configured in yourenvis correctly picked up by thebuild.shsetup and local collector spawned on it.