-
Notifications
You must be signed in to change notification settings - Fork 111
Updates to add column and row pinning as well as entry-mapped layout #9264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I've just kicked off: @:data-explorer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took a look at a few of the files and found a few small things to fix and figured I'd leave a comment about this now. I'm going to do another pass on this PR in a bit.
...rerPanel/components/addEditRowFilterModalPopup/components/columnSelectorDataGridInstance.tsx
Show resolved
Hide resolved
...rerPanel/components/addEditRowFilterModalPopup/components/columnSelectorDataGridInstance.tsx
Outdated
Show resolved
Hide resolved
src/vs/workbench/browser/positronDataGrid/classes/dataGridInstance.tsx
Outdated
Show resolved
Hide resolved
src/vs/workbench/browser/positronDataGrid/classes/dataGridInstance.tsx
Outdated
Show resolved
Hide resolved
src/vs/workbench/browser/positronDataGrid/classes/dataGridInstance.tsx
Outdated
Show resolved
Hide resolved
src/vs/workbench/browser/positronDataGrid/classes/dataGridInstance.tsx
Outdated
Show resolved
Hide resolved
src/vs/workbench/browser/positronDataGrid/components/dataGridColumnHeader.css
Show resolved
Hide resolved
src/vs/workbench/browser/positronDataGrid/components/dataGridColumnHeader.css
Show resolved
Hide resolved
src/vs/workbench/browser/positronDataGrid/components/dataGridColumnHeader.css
Outdated
Show resolved
Hide resolved
src/vs/workbench/browser/positronDataGrid/components/dataGridColumnHeader.css
Show resolved
Hide resolved
src/vs/workbench/browser/positronDataGrid/components/dataGridRowCell.tsx
Outdated
Show resolved
Hide resolved
src/vs/workbench/services/positronDataExplorer/browser/tableDataDataGridInstance.tsx
Show resolved
Hide resolved
src/vs/workbench/services/positronDataExplorer/browser/tableDataDataGridInstance.tsx
Outdated
Show resolved
Hide resolved
src/vs/workbench/services/positronDataExplorer/browser/tableDataDataGridInstance.tsx
Outdated
Show resolved
Hide resolved
src/vs/workbench/services/positronDataExplorer/common/columnSchemaCache.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/services/positronDataExplorer/common/tableDataCache.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things are looking good at this point to me!
This PR adds column pinning and row pinning as well as entry-mapped layout to Data Explorer.
Tests:
@:data-explorer
@:web
@:win
Release Notes
New Features
Bug Fixes
QA Notes