Skip to content

Conversation

dhruvisompura
Copy link
Contributor

@dhruvisompura dhruvisompura commented Aug 29, 2025

Addresses #8529

This PR adds the missing Enter/Space keyboard support for our filter search bars. This change effects the summary panel search bar and the variables pane search bar.

I also removed a couple duplicate search/filter components that are not being used.

Screen.Recording.2025-09-02.at.9.49.42.AM.mov

Release Notes

New Features

  • N/A

Bug Fixes

  • N/A

QA Notes

@:variables @:data-explorer @:accessibility

@midleman
Copy link
Contributor

Thanks for fixing so fast! Quick question, when the "x" is selected and the user hits Enter to clear the search data, where should the focus go next? I assumed it would be in the search input (it's currently not)... but I'm not sure.

@dhruvisompura
Copy link
Contributor Author

Thanks for fixing so fast! Quick question, when the "x" is selected and the user hits Enter to clear the search data, where should the focus go next? I assumed it would be in the search input (it's currently not)... but I'm not sure.

It should be in the search input! I'll take a look into this. Thanks for catching that!

Copy link
Contributor

@nstrayer nstrayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Sorry I thought I had reviewed this a while back!)

Looks good to me. I always like a good PR with a 17 times more deleted code than added.

@dhruvisompura dhruvisompura merged commit 149b6b3 into main Sep 5, 2025
9 checks passed
@dhruvisompura dhruvisompura deleted the feature/keyboard-support-for-filter-bar branch September 5, 2025 16:49
@github-actions github-actions bot locked and limited conversation to collaborators Sep 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants