Skip to content

Commit 149b6b3

Browse files
Add keyboard support for filter bar (#9236)
1 parent 129da11 commit 149b6b3

File tree

5 files changed

+18
-313
lines changed

5 files changed

+18
-313
lines changed

src/vs/platform/positronActionBar/browser/components/actionBarFilter.tsx

Lines changed: 18 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,16 @@ export const ActionBarFilter = forwardRef<ActionBarFilterHandle, ActionBarFilter
5050
inputRef.current.value = '';
5151
setFilterText('');
5252
props.onFilterTextChanged('');
53+
// Move focus back to the input after clearing the text.
54+
inputRef.current.focus();
55+
};
56+
57+
// Button clear key down handler.
58+
const buttonClearKeyDownHandler = (e: React.KeyboardEvent<HTMLButtonElement>) => {
59+
if (e.code === 'Enter' || e.code === 'Space') {
60+
e.preventDefault();
61+
buttonClearClickHandler();
62+
}
5363
};
5464

5565
useImperativeHandle(ref, () => ({
@@ -67,16 +77,21 @@ export const ActionBarFilter = forwardRef<ActionBarFilterHandle, ActionBarFilter
6777
<input
6878
ref={inputRef}
6979
className='text-input'
70-
placeholder={(() => localize('positronFilterPlaceholder', "filter"))()}
80+
placeholder={(() => localize('positronFilterPlaceholder', "Filter"))()}
7181
type='text'
7282
value={filterText}
7383
onBlur={() => setFocused(false)}
7484
onChange={changeHandler}
7585
onFocus={() => setFocused(true)}
7686
/>
7787
{filterText !== '' && (
78-
<button className='clear-button'>
79-
<div className={'codicon codicon-positron-search-cancel'} onClick={buttonClearClickHandler} />
88+
<button
89+
aria-label={(() => localize('positronClearFilter', "Clear filter"))()}
90+
className='clear-button'
91+
onClick={buttonClearClickHandler}
92+
onKeyDown={buttonClearKeyDownHandler}
93+
>
94+
<div className={'codicon codicon-positron-search-cancel'} />
8095
</button>
8196
)}
8297
</div>

src/vs/platform/positronActionBar/browser/components/actionBarFind.css

Lines changed: 0 additions & 97 deletions
This file was deleted.

src/vs/platform/positronActionBar/browser/components/actionBarFind.tsx

Lines changed: 0 additions & 77 deletions
This file was deleted.

src/vs/platform/positronActionBar/browser/components/actionBarSearch.css

Lines changed: 0 additions & 70 deletions
This file was deleted.

src/vs/platform/positronActionBar/browser/components/actionBarSearch.tsx

Lines changed: 0 additions & 66 deletions
This file was deleted.

0 commit comments

Comments
 (0)