Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: content layout shift on category #744

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: content layout shift on category #744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8e9cddf
fix: cls
rbedeoan-plenty Oct 18, 2024
d52f7c3
fix: changelog
rbedeoan-plenty Oct 18, 2024
e151af3
Merge branch 'main' into fix-content-layout-shift-on-category
rbedeoan-plenty Oct 18, 2024
b55ab7b
fix: changelog
rbedeoan-plenty Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions apps/web/layouts/default.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
<template>
<div>
<UiHeader />
<NarrowContainer v-if="breadcrumbs?.length" class="p-4 md:px-0">
<LazyUiBreadcrumbs :breadcrumbs="breadcrumbs" />
</NarrowContainer>
<main>
<main class="min-h-screen">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to figure out why this was there in the first place. Why did we need min-height: 100vh on <main>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a comment in card, i can provide more context if you have time.pm.

<slot />
</main>
<UiNavbarBottom v-if="viewport.isLessThan('lg')" />
Expand Down
5 changes: 5 additions & 0 deletions apps/web/pages/[...slug].vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@
class="relative"
:class="{ 'pointer-events-none opacity-50': loading }"
>
<div class="sm:min-h-[56px] min-h-[59px]">
<NarrowContainer v-if="!loading && breadcrumbs?.length" class="p-4 md:px-0">
<LazyUiBreadcrumbs :breadcrumbs="breadcrumbs" />
</NarrowContainer>
</div>
<SfLoaderCircular v-if="loading" class="fixed top-[50%] right-0 left-0 m-auto z-[99999]" size="2xl" />
<CategoryPageContent
v-if="productsCatalog?.products"
Expand Down
5 changes: 5 additions & 0 deletions apps/web/pages/product/[slug].vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
<template>
<NuxtLayout name="default" :breadcrumbs="breadcrumbs">
<div class="sm:min-h-[56px] min-h-[59px]">
<NarrowContainer v-if="breadcrumbs?.length" class="p-4 md:px-0">
<LazyUiBreadcrumbs :breadcrumbs="breadcrumbs" />
</NarrowContainer>
</div>
<NarrowContainer>
<div class="md:grid gap-x-6 grid-areas-product-page grid-cols-product-page">
<section class="grid-in-left-top md:h-full xl:max-h-[700px]">
Expand Down
1 change: 1 addition & 0 deletions docs/changelog/changelog_en.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

### 🩹 Fixed

- Fixed content layout shift error in category page
- Fixed an issue where product path was not reactive when category was changed.
- Automatically generate a language file for every active language, not just the default language.
- Soft login was still shown after successfully authenticating on the order confirmation page.
Expand Down
Loading