Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: content layout shift on category #744

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: content layout shift on category #744

wants to merge 4 commits into from
+12 −4

Conversation

rbedeoan-plenty
Copy link
Contributor

@rbedeoan-plenty rbedeoan-plenty commented Oct 18, 2024 •
edited by plenty-to-azure
Loading

@github-actions github-actions bot added fix Patch a bug and removed fix Patch a bug labels Oct 18, 2024
@github-actions github-actions bot added fix Patch a bug and removed fix Patch a bug labels Oct 18, 2024
@rbedeoan-plenty rbedeoan-plenty marked this pull request as ready for review October 18, 2024 07:54
@rbedeoan-plenty rbedeoan-plenty requested a review from a team as a code owner October 18, 2024 07:54
@github-actions github-actions bot added fix Patch a bug and removed fix Patch a bug labels Oct 18, 2024
@github-actions github-actions bot added fix Patch a bug and removed fix Patch a bug labels Oct 18, 2024
@rbedeoan-plenty rbedeoan-plenty enabled auto-merge (squash) October 18, 2024 08:04
Tim-M-S
Tim-M-S reviewed Oct 18, 2024
View reviewed changes
apps/web/layouts/default.vue
<LazyUiBreadcrumbs :breadcrumbs="breadcrumbs" />
</NarrowContainer>
<main>
<main class="min-h-screen">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to figure out why this was there in the first place. Why did we need min-height: 100vh on <main>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a comment in card, i can provide more context if you have time.pm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tim-M-S Tim-M-S Tim-M-S left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@rbedeoan-plenty rbedeoan-plenty

Labels
fix Patch a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rbedeoan-plenty @Tim-M-S