Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax instance check from VectorStoreRetriever to BaseRetriever #1097

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Relax instance check from VectorStoreRetriever to BaseRetriever #1097

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions phi/knowledge/langchain.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ def search(self, query: str, num_documents: Optional[int] = None) -> List[Docume
"""Returns relevant documents matching the query"""

try:
from langchain_core.vectorstores import VectorStoreRetriever
from langchain_core.retrievers import BaseRetriever
from langchain_core.documents import Document as LangChainDocument
except ImportError:
raise ImportError(
Expand All @@ -34,8 +34,8 @@ def search(self, query: str, num_documents: Optional[int] = None) -> List[Docume
logger.error("No retriever provided")
return []

if not isinstance(self.retriever, VectorStoreRetriever):
raise ValueError(f"Retriever is not of type VectorStoreRetriever: {self.retriever}")
if not isinstance(self.retriever, BaseRetriever):
raise ValueError(f"Retriever is not of type BaseRetriever: {self.retriever}")

_num_documents = num_documents or self.num_documents
logger.debug(f"Getting {_num_documents} relevant documents for query: {query}")
Expand Down