Relax instance check from VectorStoreRetriever to BaseRetriever
#1097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should the log message mentioning vectorstore also be adjusted (line 60)? |
jacobweiss2305
approved these changes
Sep 19, 2024
|
@Joelius300 apologies for the delay on this. Do you mind adding a quick cookbook example? I want to show the difference between retreiving from doc and vectorstore. This will show that the relax is better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1096
I ran the scripts
format.sh,validate.shandtest.sh. There were some formatting changes and type warnings in other files that don't seem related to this change. The tests could not run (or only partially) because I do not have enough OpenAI quota.This is my first contribution to phidata, so I'm very happy to hear all of your feedback :)