354 cleanup postprocessing #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of conditionally down the line if lights are present as it doesn't tree-shake anyway.
Instead of base renderer
to avoid double negation
dmnsgn
reviewed
May 1, 2024
| @@ -10,6 +10,6 @@ export default (options) => ({ | |||
| bias: 0.1, | |||
| castShadows: true, | |||
| radius: 1, | |||
| // shadowMapSize: 2048, | |||
| // shadowMapSize: 2048, //TODO: MARCIN: why is this commented out? | |||
There was a problem hiding this comment.
Because we have default value and it is commented here to show it exists when/if we want to test things.
dmnsgn
reviewed
May 1, 2024
- so the git diff makes sense
- unordered imports - unused imports - unused vars
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
next / nice to have
this.pipelineCache.cache.targetsandcolorAttachmentsfor connecting pass targets / sources in render pipeline