-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dask integration #2
Open
blue442
wants to merge
51
commits into
peter-i-frazier:dask_integration
Choose a base branch
from
UW-Madison-DSI:multiprocessing_pool
base: dask_integration
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Dask integration #2
blue442
wants to merge
51
commits into
peter-i-frazier:dask_integration
from
UW-Madison-DSI:multiprocessing_pool
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p-testing into multiprocessing_pool
…p-testing into multiprocessing_pool
…kdown analysis notebooks
Pulling in master from Cornell to capture newer multigroup sims
…p-testing into multiprocessing_pool
…py to try and alleviate import issues
…p-testing into multiprocessing_pool
…p-testing into multiprocessing_pool
…p-testing into multiprocessing_pool
…p-testing into multiprocessing_pool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dask integration has been implemented and tested locally - still need to check out on the CHTC resource, but that shouldn't affect local running. Main changes are found in run_sensitivity.py, with a small change in load_parameters.py. There were also a decent number of non-functional style changes as suggested by the linter (flake8), and some changes to the notebooks and simulation files that hopefully won't be too distracting.