Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Multiple attestators to same Rank NFT #56

Closed
wants to merge 0 commits into from

Conversation

peersky
Copy link
Member

@peersky peersky commented Jul 12, 2024

WIth completion of #62 it is now possible to create multiple subjects that correspond to different Rank NFT asset minting privilege.

As we go forward, this brings a ux question of supplorting multiple subjects with absolutely identical subject. Technically right now it is possible, to create two Rank Token NFTs, with identical subject.

With this ticket, we want to create token such that it can work for every subject, but will avoid duplication of Rank NFTs.

This means that there will be one Rank NFT endpoint that can mint tokens for unlimited number of instances. Following is needed:

  • MAO Distribution instantiate workflow should be able to recognize already existing instance and attach to it another instance
  • In case of same subject, must align to common parameters following ACID framework.
  • In case of same subject, must emit indexable event that allows to group instances.

@peersky peersky linked an issue Jul 12, 2024 that may be closed by this pull request
3 tasks
Copy link

changeset-bot bot commented Jul 12, 2024

⚠️ No Changeset found

Latest commit: 9afa813

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@peersky peersky changed the title 18 factory registry Ranking instance distributor Jul 14, 2024
@peersky peersky marked this pull request as ready for review July 14, 2024 19:52
@peeramid-labs peeramid-labs deleted a comment from openzeppelin-code bot Oct 22, 2024
@peersky peersky changed the title Ranking instance distributor Add: Multiple attesting instances to same Rank NFT Oct 22, 2024
@peersky peersky changed the title Add: Multiple attesting instances to same Rank NFT Add: Multiple attestators to same Rank NFT Oct 22, 2024
@peersky peersky closed this Oct 22, 2024
@peersky peersky force-pushed the 18-factory-registry branch from 897fc96 to 9afa813 Compare October 22, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Feature: Multiple instances per Subject
1 participant