[WIP] feat: CMake improvements and Catch2 migration #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LecrisUT
force-pushed
the
cmake/improvements
branch
from
7449574 to
129d330
Compare
|
Still working on converting the tests, but is the structure of cadf5cc clear that you can build upon? |
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
- moved coverage flags within the src directory - scoped the coverage flags to current project Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
LecrisUT
force-pushed
the
cmake/improvements
branch
from
129d330 to
f9e8821
Compare
Signed-off-by: Cristian Le <[email protected]>
LecrisUT
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FeatureSummary: Nice overview displayBUILD_TESTSis not enabled,COVERAGEshould always be disabledBUILD_EXAMPLESimplies that we want to install these examples. Is that really what we want? It can be partially simplified if it is only part of the tests. @pboettch thoughts on this?readmeexample?catch2JSON-Schema-Test-Suiteclang-tidypre-commit issues. Seems to be complaining about the CMake script.Revert "[Temp] Disable clang-tidy"
Closes #266