Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fedora packaging #305

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix: Fedora packaging #305

wants to merge 2 commits into from

Conversation

LecrisUT
Copy link
Collaborator

@LecrisUT LecrisUT commented Nov 27, 2023 •
edited
Loading

Depends on: #306

@LecrisUT
Improve packit packaging
c43031b 
- Fixed tag template
- Added fedora-all and epel-9

Signed-off-by: Cristian Le <[email protected]>
@LecrisUT
Use downstream tests
3d8a426 
Signed-off-by: Cristian Le <[email protected]>
@LecrisUT
Copy link
Collaborator Author

Ok, I know what is wrong with this one. Need to fix the example and test-suite. Basically I will implement the format in: https://github.com/LecrisUT/CMake-Template to be more portable

@pboettch About the manual tests, e.g. issue-25-default-values.cpp, do you have a preference to have it in the current plain int main form or are you ok with adding either googletest or catch2?

@pboettch
Copy link
Owner

Yes, go ahead if you have time with Catch2.

@pboettch
Copy link
Owner

Please rebase on main to get the pre-commit fixes

@LecrisUT LecrisUT marked this pull request as draft November 27, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LecrisUT @pboettch