Skip to content

fix(templates): prevent infinite redirect loop on unknown paths #15614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
divyesh123-jain wants to merge 2 commits into
base: main
Choose a base branch
from
+11 −3
Open

fix(templates): prevent infinite redirect loop on unknown paths #15614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e86ff74
fix(next): handle undefined fieldTab in version diff tabs
divyesh123-jain Feb 11, 2026
8e5cbb5
fix(templates): prevent infinite redirect loop on unknown paths
divyesh123-jain Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/next/src/views/Version/RenderFieldsToDiff/fields/Tabs/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,13 @@ export const Tabs: TabsFieldDiffClientComponent = (props) => {
return null
}
const fieldTab = field.tabs?.[i]
if (!fieldTab) {
return null
}
return (
<div className={`${baseClass}__tab`} key={i}>
{(() => {
if ('name' in fieldTab && selectedLocales && fieldTab.localized) {
if (fieldTab && 'name' in fieldTab && selectedLocales && fieldTab.localized) {
// Named localized tab
return selectedLocales.map((locale, index) => {
const localizedTabProps: TabProps = {
Expand Down
3 changes: 3 additions & 0 deletions templates/ecommerce/src/app/(app)/layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import { Providers } from '@/providers'
import { InitTheme } from '@/providers/Theme/InitTheme'
import { GeistSans } from 'geist/font/sans'
import { GeistMono } from 'geist/font/mono'
import { headers } from 'next/headers'
import React from 'react'
import './globals.css'

Expand Down Expand Up @@ -40,6 +41,8 @@ const twitterSite = TWITTER_SITE ? ensureStartsWith(TWITTER_SITE, 'https://') :
} */

export default async function RootLayout({ children }: { children: ReactNode }) {
await headers()

return (
<html
className={[GeistSans.variable, GeistMono.variable].filter(Boolean).join(' ')}
Expand Down
3 changes: 2 additions & 1 deletion templates/website/src/app/(frontend)/layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,13 @@ import { Header } from '@/Header/Component'
import { Providers } from '@/providers'
import { InitTheme } from '@/providers/Theme/InitTheme'
import { mergeOpenGraph } from '@/utilities/mergeOpenGraph'
import { draftMode } from 'next/headers'
import { draftMode, headers } from 'next/headers'

import './globals.css'
import { getServerSideURL } from '@/utilities/getURL'

export default async function RootLayout({ children }: { children: React.ReactNode }) {
await headers()
const { isEnabled } = await draftMode()

return (
Expand Down
3 changes: 2 additions & 1 deletion templates/with-vercel-website/src/app/(frontend)/layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,13 @@ import { Header } from '@/Header/Component'
import { Providers } from '@/providers'
import { InitTheme } from '@/providers/Theme/InitTheme'
import { mergeOpenGraph } from '@/utilities/mergeOpenGraph'
import { draftMode } from 'next/headers'
import { draftMode, headers } from 'next/headers'

import './globals.css'
import { getServerSideURL } from '@/utilities/getURL'

export default async function RootLayout({ children }: { children: React.ReactNode }) {
await headers()
const { isEnabled } = await draftMode()

return (
Expand Down
Loading