fix(templates): prevent infinite redirect loop on unknown paths#15614
Open
divyesh123-jain wants to merge 2 commits intopayloadcms:mainfrom
Open
fix(templates): prevent infinite redirect loop on unknown paths#15614divyesh123-jain wants to merge 2 commits intopayloadcms:mainfrom
divyesh123-jain wants to merge 2 commits intopayloadcms:mainfrom
Conversation
Fixes infinite redirect loop on 404 routes in production builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes infinite redirect loop on unknown/404 routes in production builds for templates with complex layouts (ecommerce, website, with-vercel-website).
Why?
In Next.js 15+, root layouts render statically by default. However, child components like
AdminBar,Header, andFooterneed runtime access to headers/cookies. This mismatch causes the layout to attempt re-rendering multiple times when users navigate to undefined routes in production builds, resulting in an infinite redirect loop and "too many redirects" browser error.How?
Added
await headers()at the start of theRootLayoutfunction to force dynamic rendering, ensuring child components have access to runtime headers/cookies.Changes:
templates/ecommerce/src/app/(app)/layout.tsx- Addedheadersimport andawait headers()calltemplates/website/src/app/(frontend)/layout.tsx- Addedheadersto existing import andawait headers()calltemplates/with-vercel-website/src/app/(frontend)/layout.tsx- Addedheadersto existing import andawait headers()call