Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix event dict typing #1413

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Fix event dict typing #1413

merged 2 commits into from
Nov 4, 2024

Conversation

arielkr256
Copy link
Contributor

@arielkr256 arielkr256 commented Oct 29, 2024 •
edited
Loading

Background

Some alert context helpers were erroneously typing event: dict. This breaks some things after PyPanther conversion because events are type PantherEvent.

Changes

  • Remove dict typing from alert context helpers

Testing

  • make test

@arielkr256 arielkr256 requested a review from a team as a code owner October 29, 2024 21:02
@arielkr256 arielkr256 added the bug Something isn't working label Oct 29, 2024
@arielkr256 arielkr256 enabled auto-merge (squash) November 4, 2024 17:33
@arielkr256 arielkr256 merged commit bdc7a6c into develop Nov 4, 2024
8 checks passed
@arielkr256 arielkr256 deleted the fix-dict-typing branch November 4, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ben-githubs ben-githubs ben-githubs approved these changes

@kostaspap kostaspap kostaspap approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arielkr256 @kostaspap @ben-githubs