Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix event dict typing #1413

Merged
merged 2 commits into from
Nov 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions global_helpers/panther_aws_helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def aws_strip_role_session_id(user_identity_arn):
return user_identity_arn


def aws_rule_context(event: dict):
def aws_rule_context(event):
return {
"eventName": event.get("eventName", "<MISSING_EVENT_NAME>"),
"eventSource": event.get("eventSource", "<MISSING_ACCOUNT_ID>"),
Expand All @@ -41,7 +41,7 @@ def aws_rule_context(event: dict):
}


def aws_guardduty_context(event: dict):
def aws_guardduty_context(event):
return {
"description": event.get("description", "<MISSING DESCRIPTION>"),
"severity": event.get("severity", "<MISSING SEVERITY>"),
Expand Down
2 changes: 1 addition & 1 deletion global_helpers/panther_box_helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ def build_jwt_settings(response: dict) -> dict:

# 'additional_details' from box logs varies by event_type.
# This helper wraps the process of extracting those details.
def box_parse_additional_details(event: dict):
def box_parse_additional_details(event):
additional_details = event.get("additional_details", {})
if isinstance(additional_details, (str, bytes)):
try:
Expand Down
4 changes: 2 additions & 2 deletions global_helpers/panther_cloudflare_helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def map_source_to_name(event: Any) -> str:
)


def cloudflare_fw_alert_context(event: dict = None):
def cloudflare_fw_alert_context(event=None):
keep_keys = [
"Action",
"ClientIP",
Expand All @@ -57,7 +57,7 @@ def cloudflare_fw_alert_context(event: dict = None):
return context_dict


def cloudflare_http_alert_context(event: dict = None):
def cloudflare_http_alert_context(event=None):
keep_keys = [
"BotScore",
"BotScoreSrc",
Expand Down
6 changes: 3 additions & 3 deletions global_helpers/panther_crowdstrike_fdr_helpers.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
def crowdstrike_detection_alert_context(event: dict):
def crowdstrike_detection_alert_context(event):
"""Returns common context for Crowdstrike detections"""
return {
"aid": get_crowdstrike_field(event, "aid", default=""),
Expand All @@ -13,7 +13,7 @@ def crowdstrike_detection_alert_context(event: dict):
}


def crowdstrike_process_alert_context(event: dict):
def crowdstrike_process_alert_context(event):
"""Returns common process context for Crowdstrike detections"""
return {
"aid": get_crowdstrike_field(event, "aid", default=""),
Expand All @@ -28,7 +28,7 @@ def crowdstrike_process_alert_context(event: dict):
}


def crowdstrike_network_detection_alert_context(event: dict):
def crowdstrike_network_detection_alert_context(event):
"""Returns common network context for Crowdstrike detections"""
return {
"LocalAddressIP4": get_crowdstrike_field(event, "LocalAddressIP4", default=""),
Expand Down
2 changes: 1 addition & 1 deletion global_helpers/panther_duo_helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
from json import JSONDecodeError


def deserialize_administrator_log_event_description(event: dict) -> dict:
def deserialize_administrator_log_event_description(event) -> dict:
"""Intelligently try and decode a field that is usually stringified json into a python dict.

This description field seems to take the form of stringified json, So this function
Expand Down
2 changes: 1 addition & 1 deletion global_helpers/panther_lookuptable_helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def _lookup(self, match_field: str, *keys) -> list or str:
def p_matched(self):
return self._p_matched

def p_matches(self, event: dict, p_match: str = "") -> dict:
def p_matches(self, event, p_match: str = "") -> dict:
"""Collect enrichments by searching for a value match in the p_match field

Parameters:
Expand Down
2 changes: 1 addition & 1 deletion global_helpers/panther_okta_helpers.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
def okta_alert_context(event: dict):
def okta_alert_context(event):
"""Returns common context for automation of Okta alerts"""
return {
"event_type": event.get("eventtype", ""),
Expand Down