Disable expensive LambdaMethodReference by default

[carterkozak]

See #2997

LambdaMethodReference is incredibly expensive, even compared to log safety flow analysis! It was originally added to clean up the results of other excavators, not to prevent runtime failures. We will apply the cleanup asynchronously via an excavator, rather than on a per-compilation basis, delayed fixups are a reasonable tradeoff here to dramatically improve compilation performance.

While we could move the code entirely into excavator instead of maintaining it here, however that has some risk for folks who explicitly configure/disable the LambdaMethodReference check (specifically, they would fail with:
LambdaMethodReference not a valid checker name)

==COMMIT_MSG==
Disable expensive LambdaMethodReference by default
==COMMIT_MSG==

[changelog-app]

Generate changelog in changelog/@unreleased

What do the change types mean?

• feature: A new feature of the service.
• improvement: An incremental improvement in the functionality or operation of the service.
• fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
• break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
  and external consumers of the service's API (e.g. customer-written software or integrations).
• deprecation: Advertises the intention to remove service functionality without any change to the
  operation of the service itself.
• manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
  performing database surgery, ...) at the time of upgrade for it to succeed.
• migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?

• ❗The break and manual task changelog types will result in a major release!
• 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
• ✨ All others will result in a minor version release.

Type

• Feature
• Improvement
• Fix
• Break
• Deprecation
• Manual task
• Migration

Description

Disable expensive LambdaMethodReference by default

Check the box to generate changelog(s)

• Generate changelog entry

[mpritham]

Thanks!

[autorelease3]

Released 6.11.0