Disable expensive LambdaMethodReference by default (#2999)

Disable expensive LambdaMethodReference by default
palantir · Jan 17, 2025 · af73326 · af73326
1 parent 055aef8
commit af73326
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 2 deletions.
diff --git a/...ine-error-prone/src/main/java/com/palantir/baseline/errorprone/LambdaMethodReference.java b/...ine-error-prone/src/main/java/com/palantir/baseline/errorprone/LambdaMethodReference.java
@@ -52,7 +52,7 @@
 @BugPattern(
         link = "https://github.com/palantir/gradle-baseline#baseline-error-prone-checks",
         linkType = BugPattern.LinkType.CUSTOM,
-        severity = SeverityLevel.WARNING,
+        severity = SeverityLevel.SUGGESTION,
         summary = "Lambda should be a method reference")
 @SuppressWarnings("checkstyle:CyclomaticComplexity")
 public final class LambdaMethodReference extends BugChecker implements BugChecker.LambdaExpressionTreeMatcher {

diff --git a/changelog/@unreleased/pr-2999.v2.yml b/changelog/@unreleased/pr-2999.v2.yml
@@ -0,0 +1,5 @@
+type: improvement
+improvement:
+  description: Disable expensive LambdaMethodReference by default
+  links:
+  - https://github.com/palantir/gradle-baseline/pull/2999
diff --git a/...line-java/src/main/java/com/palantir/baseline/extensions/BaselineErrorProneExtension.java b/...line-java/src/main/java/com/palantir/baseline/extensions/BaselineErrorProneExtension.java
@@ -48,7 +48,6 @@ public abstract class BaselineErrorProneExtension {
             "ImplicitPublicBuilderConstructor",
             "JavaTimeDefaultTimeZone",
             "JavaTimeSystemDefaultTimeZone",
-            "LambdaMethodReference",
             "LoggerEnclosingClass",
             "LogsafeArgName",
             "ObjectsHashCodeUnnecessaryVarargs",

diff --git a/gradle-baseline-java/src/main/java/com/palantir/baseline/plugins/BaselineErrorProne.java b/gradle-baseline-java/src/main/java/com/palantir/baseline/plugins/BaselineErrorProne.java
@@ -99,6 +99,9 @@ private static void configureErrorProneOptions(ErrorProneOptions errorProneOptio
                 // https://github.com/google/error-prone/issues/4544
                 "DistinctVarargsChecker",
                 "InlineMeSuggester",
+                // LambdaMethodReference is incredibly expensive, see #2997. We leave it
+                // here to employ as a cleanup, but don't execute it in most compilations.
+                "LambdaMethodReference",
                 // We often use javadoc comments without javadoc parameter information.
                 "NotJavadoc",
                 "PreferImmutableStreamExCollections",