Upgrade to Google test 1.14.0 #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did a local build with no issues, LGTM. Note: I can't review or mark the approval since I'm not assigned. |
|
CI:
|
marcoag
approved these changes
Jan 31, 2024
Since we now have C++17 everywhere, we can remove the mpark::variant fallback. Signed-off-by: Chris Lalancette <[email protected]>
Signed-off-by: Chris Lalancette <[email protected]>
clalancette
force-pushed
the
clalancette/update-gtest-to-1.14
branch
from
0a2f54f
to
ca1f57d
Compare
|
OK, I think I figured out the difference here. I think some of the code was trying to use |
|
CI:
|
|
I'm going to go ahead and merge this one since it was already approved. If there are any followups I'll deal with them separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches the version that will be in Ubuntu 24.04, and should resolve some CMake warnings when building on that platform.
@marcoag please take a look at this and ament/googletest#27 when you get a chance.