Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert optimistic exec #8851

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

PaddyMc
Copy link
Collaborator

@PaddyMc PaddyMc commented Nov 27, 2024

What is the purpose of the change

Due to an issue with concurrent map writes stemming from the block sdk, we need to revert this PR until we have a patch version of the block sdk, the solution is to "import upstream cosmos-sdk changes to prio-nonce mempool"

see:
skip-mev/block-sdk#355

the halt is sporadic and would not fully halt the chain if validators are using systemd, as systemd would restart the node on fail, the halt looks like this:

fatal error: concurrent map writes

goroutine 5967690 [running]:
github.com/skip-mev/block-sdk/v2/block/base.(*PriorityNonceMempool[...]).Remove(0x6fc2fa0, {0x6e9d0e0, 0xc1b5526580?})
	github.com/skip-mev/block-sdk/[email protected]/block/base/priority_nonce.go:468 +0x2a5
github.com/skip-mev/block-sdk/v2/block/base.(*Mempool[...]).Remove(0x1ef601d?, {0x6e9d0e0?, 0xc1b5526580?})
	github.com/skip-mev/block-sdk/[email protected]/block/base/mempool.go:67 +0x2f
github.com/skip-mev/block-sdk/v2/block.(*LanedMempool).Remove(0x6ed4918?, {0x6e9d0e0, 0xc1b5526580})
	github.com/skip-mev/block-sdk/[email protected]/block/mempool.go:127 +0xd3
github.com/cosmos/cosmos-sdk/baseapp.(*BaseApp).runTx(0xc001656fc8, 0x7, {0xc1c8813b80, 0x26f, 0x26f})
	github.com/cosmos/[email protected]/baseapp/baseapp.go:944 +0xf90
github.com/cosmos/cosmos-sdk/baseapp.(*BaseApp).deliverTx(0xc001656fc8, {0xc1c8813b80?, 0x26f?, 0xc028b8c2c0?})
	github.com/cosmos/[email protected]/baseapp/baseapp.go:768 +0xb1
github.com/cosmos/cosmos-sdk/baseapp.(*BaseApp).internalFinalizeBlock(0xc001656fc8, {0x6ed4bc8, 0xc093fefd60}, 0xc028b57080)
	github.com/cosmos/[email protected]/baseapp/abci.go:793 +0x125c
github.com/cosmos/cosmos-sdk/baseapp/oe.(*OptimisticExecution).Execute.func1()
	github.com/cosmos/[email protected]/baseapp/oe/optimistic_execution.go:108 +0x84
created by github.com/cosmos/cosmos-sdk/baseapp/oe.(*OptimisticExecution).Execute in goroutine 24944
	github.com/cosmos/[email protected]/baseapp/oe/optimistic_execution.go:106 +0x545

Testing and Verifying

  • review code

@PaddyMc PaddyMc added A:no-changelog V:state/compatible/backport State machine compatible PR, should be backported A:backport/v27.x backport patches to v27.x branch labels Nov 27, 2024
Copy link
Contributor

coderabbitai bot commented Nov 27, 2024

Walkthrough

The pull request includes updates to the CHANGELOG.md file, documenting changes for the Osmosis project, including new features, improvements, and bug fixes across various versions. Additionally, modifications to the cmd/osmosisd/cmd/root.go file enhance asset list handling and configuration management through new functions and improved logic. These changes aim to improve the command-line interface's functionality and usability.

Changes

File Change Summary
CHANGELOG.md Updated to reflect recent changes, including entries for optimistic execution and a chore to bump the cometbft version. Sections for versions v27.0.0, v26.0.1, and v26.0.0 have been populated with relevant updates.
cmd/osmosisd/cmd/root.go Enhanced asset list loading logic, added a custom writer for output formatting, modified command initialization, and introduced functions for configuration management and command structure improvements.
- Function added: UpdateAssetListCmd
- Function added: genAutoCompleteCmd
- Logic modified in loadAssetList
- Method added: Write in customWriter

Possibly related PRs

Suggested labels

V:state/breaking, A:no-changelog

Suggested reviewers

  • czarcas7ic
  • ValarDragon

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between d652dfb and e334408.

📒 Files selected for processing (2)
  • CHANGELOG.md (0 hunks)
  • cmd/osmosisd/cmd/root.go (0 hunks)
💤 Files with no reviewable changes (2)
  • CHANGELOG.md
  • cmd/osmosisd/cmd/root.go

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v27.x backport patches to v27.x branch A:no-changelog V:state/compatible/backport State machine compatible PR, should be backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant