Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert optimistic exec (backport #8851) #8855

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 28, 2024

What is the purpose of the change

Due to an issue with concurrent map writes stemming from the block sdk, we need to revert this PR until we have a patch version of the block sdk, the solution is to "import upstream cosmos-sdk changes to prio-nonce mempool"

see:
skip-mev/block-sdk#355

the halt is sporadic and would not fully halt the chain if validators are using systemd, as systemd would restart the node on fail, the halt looks like this:

fatal error: concurrent map writes

goroutine 5967690 [running]:
github.com/skip-mev/block-sdk/v2/block/base.(*PriorityNonceMempool[...]).Remove(0x6fc2fa0, {0x6e9d0e0, 0xc1b5526580?})
	github.com/skip-mev/block-sdk/[email protected]/block/base/priority_nonce.go:468 +0x2a5
github.com/skip-mev/block-sdk/v2/block/base.(*Mempool[...]).Remove(0x1ef601d?, {0x6e9d0e0?, 0xc1b5526580?})
	github.com/skip-mev/block-sdk/[email protected]/block/base/mempool.go:67 +0x2f
github.com/skip-mev/block-sdk/v2/block.(*LanedMempool).Remove(0x6ed4918?, {0x6e9d0e0, 0xc1b5526580})
	github.com/skip-mev/block-sdk/[email protected]/block/mempool.go:127 +0xd3
github.com/cosmos/cosmos-sdk/baseapp.(*BaseApp).runTx(0xc001656fc8, 0x7, {0xc1c8813b80, 0x26f, 0x26f})
	github.com/cosmos/[email protected]/baseapp/baseapp.go:944 +0xf90
github.com/cosmos/cosmos-sdk/baseapp.(*BaseApp).deliverTx(0xc001656fc8, {0xc1c8813b80?, 0x26f?, 0xc028b8c2c0?})
	github.com/cosmos/[email protected]/baseapp/baseapp.go:768 +0xb1
github.com/cosmos/cosmos-sdk/baseapp.(*BaseApp).internalFinalizeBlock(0xc001656fc8, {0x6ed4bc8, 0xc093fefd60}, 0xc028b57080)
	github.com/cosmos/[email protected]/baseapp/abci.go:793 +0x125c
github.com/cosmos/cosmos-sdk/baseapp/oe.(*OptimisticExecution).Execute.func1()
	github.com/cosmos/[email protected]/baseapp/oe/optimistic_execution.go:108 +0x84
created by github.com/cosmos/cosmos-sdk/baseapp/oe.(*OptimisticExecution).Execute in goroutine 24944
	github.com/cosmos/[email protected]/baseapp/oe/optimistic_execution.go:106 +0x545

Testing and Verifying

@PaddyMc PaddyMc merged commit 8f7017e into v27.x Nov 28, 2024
1 check passed
@PaddyMc PaddyMc deleted the mergify/bp/v27.x/pr-8851 branch November 28, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant