Skip to content

Conversation

@kelson42
Copy link
Contributor

@kelson42 kelson42 commented Apr 16, 2025

@veloman-yunkan can you please fix/adapt the code to this, review en merge?

@kelson42 kelson42 added this to the 9.3.0 milestone Apr 16, 2025
@kelson42 kelson42 requested a review from veloman-yunkan April 16, 2025 19:50
@codecov
Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.57%. Comparing base (720f841) to head (f775805).
Report is 75 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #971   +/-   ##
=======================================
  Coverage   57.57%   57.57%           
=======================================
  Files          98       98           
  Lines        4625     4625           
  Branches     1926     1925    -1     
=======================================
  Hits         2663     2663           
  Misses        695      695           
  Partials     1267     1267           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@veloman-yunkan
Copy link
Collaborator

veloman-yunkan commented Apr 17, 2025

@veloman-yunkan can you please fix/adapt the code to this, review en merge? It should fix #961

@kelson42 I will look into #961 but I don't think that this PR may fix it. Instead, kiwix/kiwix-build#814 is the PR that may address that failure.

On another note, I updated this PR with a change that removes the temporary code needed to support backward incompatible ZIM files with titleIdxPos set to 0.

@kelson42 kelson42 merged commit 069ab63 into main Apr 17, 2025
33 of 34 checks passed
@kelson42 kelson42 deleted the use-zim-testing-suite-0.8.0 branch April 17, 2025 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants