Merge pull request #971 from openzim/use-zim-testing-suite-0.8.0

kelson42 · web-flow · commit 069ab63ef15a · 2025-04-17T10:36:05.000+02:00
Use latest zim-testing-suite
diff --git a/scripts/download_test_data.py b/scripts/download_test_data.py
@@ -26,7 +26,7 @@
 import tarfile
 import sys
 
-TEST_DATA_VERSION = "0.7.0"
+TEST_DATA_VERSION = "0.8.0"
 ARCHIVE_URL_TEMPL = "https://github.com/openzim/zim-testing-suite/releases/download/{version}/zim-testing-suite-{version}.tar.gz"
 
 if __name__ == "__main__":
diff --git a/src/fileheader.cpp b/src/fileheader.cpp
@@ -125,12 +125,7 @@ namespace zim
   }
 
   bool Fileheader::hasTitleListingV0() const {
-    // A non-released version of libzim existed which signaled the absence of
-    // the title index v0 by setting titleIdxPos to 0 (instead of 0xff..ff).
-    // Such ZIM files are buggy since they cannot be opened by earlier version
-    // of libzim, but we temporarily acknowledge their existence until they are
-    // removed from zim-testing-suite.
-    return titleIdxPos != 0 && titleIdxPos != offset_type(-1);
+    return titleIdxPos != offset_type(-1);
   }
 
   void Fileheader::sanity_check() const {

Original file line number	Diff line number	Diff line change
`@@ -125,12 +125,7 @@ namespace zim`
`125`	`125`	`}`
`126`	`126`
`127`	`127`	`bool Fileheader::hasTitleListingV0() const {`
`128`		`- // A non-released version of libzim existed which signaled the absence of`
`129`		`- // the title index v0 by setting titleIdxPos to 0 (instead of 0xff..ff).`
`130`		`- // Such ZIM files are buggy since they cannot be opened by earlier version`
`131`		`- // of libzim, but we temporarily acknowledge their existence until they are`
`132`		`- // removed from zim-testing-suite.`
`133`		`- return titleIdxPos != 0 && titleIdxPos != offset_type(-1);`
	`128`	`+ return titleIdxPos != offset_type(-1);`
`134`	`129`	`}`
`135`	`130`
`136`	`131`	`void Fileheader::sanity_check() const {`