Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[thci] convert Python2 script to Python3 #310

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

yangsong-cnyn
Copy link
Contributor

@yangsong-cnyn yangsong-cnyn commented Jan 2, 2025

Migrate commissioner_thci scripts to Python 3;
Use the 2to3 tool for python2 to python3 conversion

Use flynt to convert .format(...) style string formatting to the modern f-strings

Copy link
Contributor

@superwhd superwhd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall with a nit

tools/commissioner_thci/example_send_mlr.py Outdated Show resolved Hide resolved
@yangsong-cnyn yangsong-cnyn self-assigned this Jan 7, 2025
@yangsong-cnyn yangsong-cnyn requested a review from wgtdkp January 8, 2025 02:47
@yangsong-cnyn yangsong-cnyn marked this pull request as ready for review January 8, 2025 03:15
@yangsong-cnyn yangsong-cnyn requested a review from jwhui January 9, 2025 03:08
@jwhui jwhui changed the title [thci] Convert Python2 script to Python3 [thci] convert Python2 script to Python3 Jan 9, 2025
@jwhui jwhui merged commit 8fffd18 into openthread:main Jan 9, 2025
33 checks passed
@yangsong-cnyn yangsong-cnyn deleted the python2_to_3 branch January 10, 2025 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants