Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add git files and vim modeline to demo resources #272

Merged
merged 2 commits into from
Sep 2, 2016

Conversation

ThomDietrich
Copy link
Member

Regarding the demo package: The following additions make tracking of a users configuration in a git/GitHub repository easier.

.gitattributes

.gitignore

  • providing a default gitignore with commented examples

vim modeline

Thomas Dietrich added 2 commits September 2, 2016 13:37
Signed-off-by: Thomas Dietrich <[email protected]>
Signed-off-by: Thomas Dietrich <[email protected]>
@kaikreuzer
Copy link
Member

The extension // vim: syntax=Xtend syntax=openhab will additionally make this compatible with https://github.com/cyberkov/openhab-vim

Shall we move these files directly somewhere to the distro and add this option in the documentation?

@kaikreuzer kaikreuzer merged commit 4581949 into openhab:master Sep 2, 2016
@ThomDietrich
Copy link
Member Author

Thanks for merging! can you rephrase your question?

@kaikreuzer
Copy link
Member

What I meant is that https://github.com/cyberkov/openhab-vim mainly contains two simple files, which people can copy to their .vim folder. I wondered if we should put these files in the openhab-distro repo (and potentially even package them in the distro zip as well (although I do not have a good suggestion for the folder where to put them).

@ThomDietrich
Copy link
Member Author

It's arguable if patching vim is a task of the openHAB setup. There is the exact same file ready for nano, would we have to add this one too? I have btw. the open issue cyberkov/openhab-vim#2 asking the developer to add "Xtend" as a syntax, which brings us to the next question: Should vim be patched for openHAB or for Xtend in the long run?

Both vim and nano syntax highlightings are by the way now also part of openHABian.

If you want to continue this discussion, let's create an issue for it.

@kaikreuzer
Copy link
Member

Ok, created cyberkov/openhab-vim#3 for further discussion.

@ThomDietrich
Copy link
Member Author

The vim modeline part of this PR is now broken.
GitHub must have changed something in it's highlighting engine. // vim: syntax=Xtend syntax=openhab is not valid anymore, // vim: syntax=Xtend is working but is in conflict with "openhab-vim". Discussed here: cyberkov/openhab-vim#2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants