Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Xtend as syntax #2

Open
ThomDietrich opened this issue Aug 29, 2016 · 2 comments
Open

Add Xtend as syntax #2

ThomDietrich opened this issue Aug 29, 2016 · 2 comments

Comments

@ThomDietrich
Copy link

ThomDietrich commented Aug 29, 2016

Hey,
your great addition is now part of openHABian: https://community.openhab.org/t/openhabian-hassle-free-rpi-image/13379
openhab/openhabian@9c5650f
Thanks!

When testing, I ran across one problem though. GitHub utilizes an app called Linguist to highlight source code. It is of course not able to highlight .rules files. The solution to this is to put a vim modeline at the end of the file: // vim: syntax=Xtend (Example)
This however collides with your syntax=openhab and highlighting is disabled.

Would you be okay to add Xtend as an alternative language to your repo?

In return adding "filetype" to my files would not be a problem. I was about to propose the whole thing as a PR against the demo config package.

@ThomDietrich
Copy link
Author

@cyberkov This issue is still important. The situation even got worse as the "double feature" introduced in openhab/openhab-distro#272 doesn't work anymore, GitHub must have changed their highlighting mechanism (check the two examples above). Are you able to look into that? You are probably the only one around here with experience in vim scripting... would be a big help!

@ThomDietrich
Copy link
Author

@cyberkov could you please let me know what you think? Even a "I don't care" would be better than silence...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant