Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛(frontend) fix Enroll now translation #2553

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

igobranco
Copy link
Collaborator

When using an external LMS, the CTA Enroll now on course runs isn't being translated.

Replace #2246

Screenshot on French, is still showing the Enroll now on English.
image

Fixed version:
image

The course run needs to have something completely different URL that don't match the course regex configured.
Ex: https://lms.nau.edu.pt/course_modes/choose/course-v1:NOVA+FEEF+2023_T2/

To test locally, it requires to add to the file src/frontend/i18n/locales/fr-FR.json

  "components.SyllabusCourseRun.enrollNow": {
    "description": "CTA for users to enroll on ongoing of future open course.",
    "message": "S'inscrire maintenant"
  },
  "components.SyllabusCourseRunCompacted.enrollNow": {
    "description": "CTA for users to enroll on ongoing of future open course.",
    "message": "S'inscrire maintenant"
  }

When using an external LMS, the CTA Enroll now on course runs
isn't being translated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant