-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛(frontend) fix Enroll now translation #2246
🐛(frontend) fix Enroll now translation #2246
Conversation
f1ff478
to
b4fb3df
Compare
When using an external LMS, the CTA Enroll now on course runs isn't being translated.
b4fb3df
to
042d91b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those labels should have been translated by the backend 🤔
richie/src/richie/apps/courses/models/course.py
Lines 55 to 56 in f47f5b0
ONGOING_OPEN: _("enroll now"), | |
FUTURE_OPEN: _("enroll now"), |
@jbpenrath I think it doesn't come from backend, but from the frontend. richie/src/frontend/js/utils/CourseRuns/index.ts Lines 12 to 79 in eae94fe
|
Replaced by #2553 |
When using an external LMS, the CTA
Enroll now
on course runs isn't being translated.Screenshot on french, is still showing the
Enroll now
on english.After applying this fix and translate it on
src/frontend/i18n/locales/fr-FR.json
: