Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP] re-order dependency installations in order to optimise building caches #98

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions template/php7/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
# start with the official Composer image and name it
# Start with the official Composer image and name it
FROM composer:1.7 AS composer

# continue with the official PHP image
# Continue with the official PHP image
FROM php:7.2-alpine

# copy the Composer PHAR from the Composer image into the PHP image
# Copy the Composer PHAR from the Composer image into the PHP image
COPY --from=composer /usr/bin/composer /usr/bin/composer

# Composer requirements
Expand All @@ -17,36 +17,36 @@ RUN apk add --no-cache git && \
curl -sSL https://github.com/openfaas/faas/releases/download/0.9.6/fwatchdog > /usr/bin/fwatchdog && \
chmod +x /usr/bin/fwatchdog

# create non-root user
# Create non-root user
RUN addgroup -S app && adduser -S -g app app && \
mkdir -p /home/app

# Import function
WORKDIR /home/app
COPY index.php ./
COPY ./function ./function
WORKDIR /home/app/function

# Install php extensions
# Install PHP extensions
COPY ./function/php-extension.sh .
RUN [[ -f php-extension.sh ]] && sh ./php-extension.sh && \
chown -R app /home/app

# Entry
# Install Composer dependencies
COPY ./function/composer* ./
USER app

# Install Composer Dependecies
RUN [[ -f composer.lock || -f composer.json ]] && composer install --no-dev

USER root

# Cleanup
RUN apk del git && \
rm -rf /usr/src/php && \
{ find /usr/local/lib -type f -print0 | xargs -0r strip --strip-all -p 2>/dev/null || true; }

USER app
# Copy the function source as very end to optimise building caches
COPY ./function/ .
RUN chown -R app /home/app

WORKDIR /home/app
USER app
ENV fprocess="php index.php"
HEALTHCHECK --interval=3s CMD [ -e /tmp/.lock ] || exit 1
CMD ["fwatchdog"]