Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHP] re-order dependency installations in order to optimise building caches #98

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[PHP] re-order dependency installations in order to optimise building caches #98

wants to merge 1 commit into from

Conversation

itscaro
Copy link
Contributor

@itscaro itscaro commented Oct 25, 2018 •
edited
Loading

Description

When dependencies/requirements are not changed, these build steps should be cached.

Motivation and Context

Which issue(s) this PR fixes

Close #97

How Has This Been Tested?

Manually by changing Dockerfile

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PHP] Optimise building cache
1 participant
@itscaro