Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: empty state for library selection on component picker [FC-0062] #1440

Conversation

rpenido
Copy link
Contributor

@rpenido rpenido commented Oct 25, 2024

Description

This PR fixes the empty state text for adding library content if the user can't access any library.

image

Supporting information

Related to:

Testing information

Note: If you still see some libraries, make sure that these libraries don't allow public read
image


Private ref: FAL-3917

@rpenido rpenido requested a review from a team as a code owner October 25, 2024 19:06
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 25, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @rpenido!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-tnl. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.25%. Comparing base (4d4adce) to head (849d24a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1440      +/-   ##
==========================================
+ Coverage   93.24%   93.25%   +0.01%     
==========================================
  Files        1052     1052              
  Lines       20450    20456       +6     
  Branches     4363     4380      +17     
==========================================
+ Hits        19068    19076       +8     
+ Misses       1322     1317       -5     
- Partials       60       63       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@DanielVZ96 DanielVZ96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 My only suggestion would be to make pagination conditional to having libraries available, but I'll leave that up to you.

  • I tested this: (describe what you tested)
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation
  • I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository.

@rpenido
Copy link
Contributor Author

rpenido commented Oct 28, 2024

My only suggestion would be to make pagination conditional to having libraries available

Great suggestion!
Added here: 353adc4

@rpenido rpenido requested a review from ChrisChV October 28, 2024 17:34
@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Oct 28, 2024
@ChrisChV ChrisChV merged commit ecfe27b into openedx:master Oct 28, 2024
6 checks passed
@ChrisChV ChrisChV deleted the rpenido/fal-3917-change-text-on-empty-state-for-adding-library-content branch October 28, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants