Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable publish button on library after component edit [FC-0062] #1446

Conversation

rpenido
Copy link
Contributor

@rpenido rpenido commented Oct 29, 2024

Description

This PR fixes the following bug:

After publishing a library then editing a component, the "Publish" button in Library Info doesn't become enabled until you refresh

Additional information

Related to:

Testing information

  • Open the library home for a library
  • Open the library sidebar and publish the library
  • Make sure the "Publish" button is disabled
  • Click on a component and open the component's sidebar
  • Edit the name of the component
  • Open the library sidebar again and check if the "Publish" button is ENABLED
  • Publish the library again to reset the status, and make sure the "Publish" button is disabled
  • Click on the three-dot menu on a component card and click on edit to open the component editor modal
  • Change the component content
  • Open the library sidebar again and check if the "Publish" button is ENABLED

Private ref: FAL-3923

@rpenido rpenido requested a review from a team as a code owner October 29, 2024 15:44
@openedx-webhooks
Copy link

Thanks for the pull request, @rpenido!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-tnl. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 29, 2024
@rpenido rpenido changed the title fix: enable publish button on library after component edit fix: enable publish button on library after component edit [FC-0062] Oct 29, 2024
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.27%. Comparing base (ecfe27b) to head (c9b0c9e).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1446      +/-   ##
==========================================
+ Coverage   93.25%   93.27%   +0.02%     
==========================================
  Files        1052     1052              
  Lines       20458    20462       +4     
  Branches     4382     4372      -10     
==========================================
+ Hits        19078    19086       +8     
+ Misses       1317     1313       -4     
  Partials       63       63              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Oct 29, 2024
@rpenido rpenido requested a review from DanielVZ96 October 31, 2024 12:58
@rpenido
Copy link
Contributor Author

rpenido commented Oct 31, 2024

Hi @DanielVZ96! This is ready of review.

Copy link
Contributor

@DanielVZ96 DanielVZ96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I tested this
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation
  • I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository.

@rpenido rpenido requested a review from ChrisChV October 31, 2024 20:22
@ChrisChV ChrisChV merged commit 949e4ac into openedx:master Nov 1, 2024
7 checks passed
@ChrisChV ChrisChV deleted the rpenido/fal-3923-fix-library-publish-button-disabled branch November 1, 2024 18:58
ChrisChV pushed a commit that referenced this pull request Nov 4, 2024
…C-0062] (#1447)

This PR fixes the following bug: After publishing a library then editing a component, the "Publish" button in Library Info doesn't become enabled until you refresh
Fixes: #1455
Backport: #1446
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants