Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Digest Updater Action] Update Runtimes Images #731

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 4, 2024

🚀 This is an automated Pull Request.
Created by /.github/workflows/runtimes-digest-updater-upstream.yaml

This PR updates the following files:

  • All the runtime images across /jupyter/datascience/ubi*-python-*/runtime-images/*.json paths

IMPORTANT NOTE: Remember to delete the digest-updater-11184496376 branch after merging the changes

@openshift-ci openshift-ci bot requested review from atheo89 and jstourac October 4, 2024 17:46
Copy link
Contributor

openshift-ci bot commented Oct 4, 2024

Hi @github-actions[bot]. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@harshad16
Copy link
Member

/lgtm
/approve
/ok-to-test

@harshad16 harshad16 added needs-ok-to-test tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. and removed ok-to-test labels Oct 4, 2024
@openshift-ci openshift-ci bot added the lgtm label Oct 4, 2024
Copy link
Contributor

openshift-ci bot commented Oct 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Oct 4, 2024
@harshad16
Copy link
Member

merging to get the build triggered.

@harshad16 harshad16 merged commit c274830 into 2024b Oct 4, 2024
12 of 14 checks passed
@harshad16 harshad16 deleted the digest-updater-11184496376 branch October 4, 2024 20:14
@jstourac
Copy link
Member

jstourac commented Oct 5, 2024

@harshad16 I can see that you updated the runtime images but didn't update the params.env file with the regular images - https://github.com/opendatahub-io/notebooks/tree/main/manifests/base . Is that intentional? Do we rely on the standard main to 2024b sync in this case? If so, what is the reason for this different approach? 🤔

Okay, I guess I got it... you had to update runtime images at least here so that they are baked into the 2024b images. References in params.env from this branch aren't that important right now, I suppose...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-ok-to-test tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants