Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Digest Updater Action] Update Runtimes Images #732

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 4, 2024

🚀 This is an automated Pull Request.
Created by /.github/workflows/runtimes-digest-updater-upstream.yaml

This PR updates the following files:

  • All the runtime images across /jupyter/datascience/ubi*-python-*/runtime-images/*.json paths

IMPORTANT NOTE: Remember to delete the digest-updater-11184360530 branch after merging the changes

@openshift-ci openshift-ci bot requested review from caponetto and harshad16 October 4, 2024 17:48
Copy link
Contributor

openshift-ci bot commented Oct 4, 2024

Hi @github-actions[bot]. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@harshad16 harshad16 added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Oct 4, 2024
Copy link
Contributor

openshift-ci bot commented Oct 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Oct 4, 2024
@harshad16 harshad16 merged commit ab54851 into main Oct 4, 2024
49 of 63 checks passed
@harshad16 harshad16 deleted the digest-updater-11184360530 branch October 4, 2024 20:16
@jstourac
Copy link
Member

jstourac commented Oct 5, 2024

Hi @harshad16, I can see that you had to manually intervene for the two of the rocm runtime images. I tried to trigger this GHA on my fork and all the images got updated properly, see:

So I will consider this manual intervention as some env issue not expecting this to happen again. Please, let me know in case I missed something and I should investigate and try to debug the problem so it won't happen again.

FTR - similar change for the 2024b branch is in #731.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants