Skip to content

Conversation

@tfoote
Copy link
Collaborator

@tfoote tfoote commented Feb 12, 2025

No description provided.

@Yadunund
Copy link
Collaborator

Looks like this PR has some conflicts.

Signed-off-by: Tully Foote <[email protected]>
Signed-off-by: Tully Foote <[email protected]>
@tfoote
Copy link
Collaborator Author

tfoote commented Feb 13, 2025

Hmm, we're running out of disk space.

The default runners are only officially 14GB: https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners

There's some more info in this extension https://github.com/marketplace/actions/maximize-build-disk-space

I might try this approach next: easimon/maximize-build-space#45

@tfoote
Copy link
Collaborator Author

tfoote commented Feb 13, 2025

Conflicts resolved and CI passing running all the way through to validate that submission.csv is created.

Copy link
Collaborator

@Yadunund Yadunund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! LGTM with a minor suggestion.

@@ -1,6 +1,5 @@
name: build
name: build_packages
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update the status badge in the README to look for the new name instead?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the badge it's only based on the filename that didn't change.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do a follow up to add the test file too.

@tfoote tfoote merged commit 134907e into main Feb 13, 2025
2 checks passed
@tfoote tfoote deleted the ci_tests branch February 13, 2025 22:48
@tfoote tfoote mentioned this pull request Feb 13, 2025
AllProAi pushed a commit to AllProAi/bpc that referenced this pull request Mar 17, 2025
* Only push new images publicly on push to main

* add new ci to test ibpc_py

Signed-off-by: Tully Foote <[email protected]>
ramamoorthyluxman pushed a commit to ramamoorthyluxman/bpc that referenced this pull request Aug 5, 2025
* Only push new images publicly on push to main

* add new ci to test ibpc_py

Signed-off-by: Tully Foote <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants