-
Notifications
You must be signed in to change notification settings - Fork 49
Working on extending some basic CI #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR has some conflicts. |
Signed-off-by: Tully Foote <[email protected]>
Signed-off-by: Tully Foote <[email protected]>
|
Hmm, we're running out of disk space. The default runners are only officially 14GB: https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners There's some more info in this extension https://github.com/marketplace/actions/maximize-build-disk-space I might try this approach next: easimon/maximize-build-space#45 |
Signed-off-by: Tully Foote <[email protected]>
|
Conflicts resolved and CI passing running all the way through to validate that submission.csv is created. |
Yadunund
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing! LGTM with a minor suggestion.
| @@ -1,6 +1,5 @@ | |||
| name: build | |||
| name: build_packages | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to update the status badge in the README to look for the new name instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the badge it's only based on the filename that didn't change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll do a follow up to add the test file too.
* Only push new images publicly on push to main * add new ci to test ibpc_py Signed-off-by: Tully Foote <[email protected]>
* Only push new images publicly on push to main * add new ci to test ibpc_py Signed-off-by: Tully Foote <[email protected]>
No description provided.