Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[opentelemetry-kube-stack] Adding additional labels #1388

Merged
merged 1 commit into from
Oct 17, 2024
Merged

[opentelemetry-kube-stack] Adding additional labels #1388

merged 1 commit into from
Oct 17, 2024

Conversation

suresh-target
Copy link
Contributor

@suresh-target suresh-target commented Oct 17, 2024 •
edited
Loading

This is to enable the option to add labels to the components such as servicemonitor.

While using a separate collector for the controlplane metrics, we need to add a label to serviceMonitors that we are planning to lookup separately (Later TA can us this label to filter the serviceMonitor lookup). This PR is specifically to fix the following error that we get while adding the label to serviceMonitor components.

- kubeEtcd.serviceMonitor.additionalLabels: Additional property component is not allowed
- kubeApiServer.serviceMonitor.additionalLabels: Additional property component is not allowed
- kubeControllerManager.serviceMonitor.additionalLabels: Additional property component is not allowed
- kubeScheduler.serviceMonitor.additionalLabels: Additional property component is not allowed

Refer the following issue for the related discussions, #1372

@suresh-target suresh-target requested review from jaronoff97 and a team as code owners October 17, 2024 03:53
@suresh-target suresh-target mentioned this pull request Oct 17, 2024
Closed
@suresh-target
Copy link
Contributor Author

@jaronoff97 - Please review

@jaronoff97 jaronoff97 merged commit 987b93d into open-telemetry:main Oct 17, 2024
3 checks passed
codeboten pushed a commit to codeboten/opentelemetry-helm-charts that referenced this pull request Nov 14, 2024
@suresh-target @codeboten
[opentelemetry-kube-stack] Adding additional labels (open-telemetry#1388
2ee8b73 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaronoff97 jaronoff97 jaronoff97 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@suresh-target @jaronoff97