Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opentelemetry-kube-stack] Adding additional labels #1382

Closed

Conversation

suresh-target
Copy link
Contributor

This is to enable the option to add labels to the components such as servicemonitor.

Adding additional labels
uptick version to 0.2.4
@suresh-target suresh-target requested review from jaronoff97 and a team as code owners October 14, 2024 05:04
@suresh-target suresh-target changed the title Adding additional labels [opentelemetry-kube-stack] Adding additional labels Oct 14, 2024
@jaronoff97
Copy link
Contributor

Right now it looks like you're only changing the pattern for the labels, i'm not exactly sure how this is solving the issue... would you mind explaining what I'm missing here? Thank you!

@suresh-target suresh-target reopened this Oct 16, 2024
@suresh-target
Copy link
Contributor Author

Right now it looks like you're only changing the pattern for the labels, i'm not exactly sure how this is solving the issue... would you mind explaining what I'm missing here? Thank you!

@jaronoff97 My plan to is to use separate collector for the controlplane metrics, for that I need to label serviceMonitor so that I would be able use that label in TA to filter the serviceMonitor lookup. This PR is specifically to fix the following error that I get while adding the label to servieMonitor components.

- kubeEtcd.serviceMonitor.additionalLabels: Additional property component is not allowed
- kubeApiServer.serviceMonitor.additionalLabels: Additional property component is not allowed
- kubeControllerManager.serviceMonitor.additionalLabels: Additional property component is not allowed
- kubeScheduler.serviceMonitor.additionalLabels: Additional property component is not allowed

@jaronoff97
Copy link
Contributor

Would this also be resolved by setting additional properties to be true? Also, can you please bump the patch version to 0.3.1 and re-run make generate-examples?

@suresh-target
Copy link
Contributor Author

Would this also be resolved by setting additional properties to be true? Also, can you please bump the patch version to 0.3.1 and re-run make generate-examples?

@jaronoff97 Yes, that is also possible.. I will modify the change to update the additional properties to true

@@ -1,6 +1,6 @@
apiVersion: v2
name: opentelemetry-kube-stack
version: 0.3.0
version: 0.3.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like the linter is still failing because of some whitespacing issues? Did your linter/formatter automatically remove extra spacing potentially?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if not, i can try running this locally and see what happens.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaronoff97 I'm closing this PR and created another one #1388

@suresh-target suresh-target deleted the additional_labels branch October 17, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants