-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[opentelemetry-kube-stack] Adding additional labels #1382
[opentelemetry-kube-stack] Adding additional labels #1382
Conversation
Adding additional labels
uptick version to 0.2.4
Right now it looks like you're only changing the pattern for the labels, i'm not exactly sure how this is solving the issue... would you mind explaining what I'm missing here? Thank you! |
7e5b04f
to
159f030
Compare
…opentelemetry-helm-charts into additional_labels
@jaronoff97 My plan to is to use separate collector for the controlplane metrics, for that I need to label serviceMonitor so that I would be able use that label in TA to filter the serviceMonitor lookup. This PR is specifically to fix the following error that I get while adding the label to servieMonitor components.
|
Would this also be resolved by setting additional properties to be true? Also, can you please bump the patch version to 0.3.1 and re-run |
@jaronoff97 Yes, that is also possible.. I will modify the change to update the additional properties to true |
@@ -1,6 +1,6 @@ | |||
apiVersion: v2 | |||
name: opentelemetry-kube-stack | |||
version: 0.3.0 | |||
version: 0.3.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks like the linter is still failing because of some whitespacing issues? Did your linter/formatter automatically remove extra spacing potentially?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if not, i can try running this locally and see what happens.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jaronoff97 I'm closing this PR and created another one #1388
This is to enable the option to add labels to the components such as servicemonitor.