Add ExAws instrumentation #152
Conversation
|
|
|
Great! It doesn't have to hold this initial version up but since you mention dynamodb, does the telemetry metadata include what is required for the required attributes for dynamodb, https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/instrumentation/aws-sdk.md#dynamodb so those can be added in the future? |
|
Unfortunately the telemetry doesn't include any of the request or response data. I can put in a PR there to see if they're willing to add it. |
Cantido
force-pushed
the
ex-aws-instrumentation
branch
from
3b299f2
to
675a93b
Compare
|
ExAws merged my PR for including request and response bodies in the telemetry, so now this instrumentation library can include DynamoDB data. I've pushed the lib code and I'm working on tests now. This will need to be fairly well-covered by tests since every API operation has its own fields to parse out. |
|
@Cantido thanks again! Is this ready now then? |
|
I've had a busy week of work, but it's nearly finished! I just need to add the tests for the remaining DynamoDB operations. |
|
That would be fabulous!! Getting all these tests done has been a bit of a barrier for me!On May 15, 2024, at 12:41 AM, Prithvi ***@***.***> wrote:
Hi @Cantido
Could I help with filling out the tests? We would love to use this from directly from the public hex repository 😁
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
ExAws just merged the necessary telemetry changes that include the AWS service name and operation in the telemetry metadata. It hasn't been included in a published version yet, but I wanted to get this ready for when it does, since my company uses ExAws heavily.