Ex aws instrumentation #330
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… unimplemented services
… AWS returns a failed response
The committers listed above are authorized under a signed CLA. |
mrnovalles
reviewed
Jul 5, 2024
| extract_attributes(response_body, Map.get(attribute_definition, :response, [])) | ||
| end | ||
|
|
||
| defp response_attributes(%{result: :error}, _), do: %{} |
There was a problem hiding this comment.
shouldn't there be a Tracer.set_status() call based on the error result?
As an example in req:
https://github.com/open-telemetry/opentelemetry-erlang-contrib/blob/main/instrumentation/opentelemetry_req/lib/opentelemetry_req.ex#L108
There was a problem hiding this comment.
I think it depends. An error response doesn't mean what the Span is doing errored, just that the response from the backend was an error, if that makes sense...
There was a problem hiding this comment.
Maybe we should set error,
The tesla telemetry middleware assumes the span is an error if the response is 4xx.
|
Thanks @prithvihv ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#152