Miscellaneous fixes for Ionic #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `Pose3::operator+` has been removed. Replaced with `Pose3::operator*`.
Note that order is reversed
* `ignerr` and similar console logging macros use the `gz` prefix now
* The enum `SphericalCoordinatesType` in the protobuf message `SphericalCoordinates` has a deprecation.
Qt5's moc doesn't seem to handle this well. Two solutions:
* Only include the needed message file header to avoid `SphericalCoordinates`
* This is not possible for `LightTuning`, so I moved the `Q_OBJECT` classes into a header file
that does not include any protobuf message headers.
Signed-off-by: Addisu Z. Taddese <[email protected]>
xiyuoh
previously approved these changes
Sep 24, 2024
Signed-off-by: Luca Della Vedova <[email protected]>
luca-della-vedova
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix
Fix applied
Pose3::operator+has been removed. Replaced withPose3::operator*. Note that order is reversedignerrand similar console logging macros use thegzprefix nowSphericalCoordinatesTypein the protobuf messageSphericalCoordinateshas a deprecation. Qt5's moc doesn't seem to handle this well. Two solutions:SphericalCoordinatesLightTuning, so I moved theQ_OBJECTclasses into a header filethat does not include any protobuf message headers.