Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port/hammer #766

Merged
merged 5 commits into from
Sep 11, 2023
Merged

Port/hammer #766

merged 5 commits into from
Sep 11, 2023

Conversation

aaronchongth
Copy link
Member

@aaronchongth aaronchongth commented Sep 8, 2023

What's new

Porting in

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

Signed-off-by: Aaron Chong <[email protected]>
(cherry picked from commit 274ca26)
Signed-off-by: Aaron Chong <[email protected]>
* Sent refresh counter app event to be void, introduced interval event

Signed-off-by: Aaron Chong <[email protected]>

* Fix prepend addition

Signed-off-by: Aaron Chong <[email protected]>

* Using 5 second periodic query interval

Signed-off-by: Aaron Chong <[email protected]>

* Refactor alert event to use void subject as well

Signed-off-by: Aaron Chong <[email protected]>

---------

Signed-off-by: Aaron Chong <[email protected]>
(cherry picked from commit 58f4869)
Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
(cherry picked from commit 3388e03)
Signed-off-by: Aaron Chong <[email protected]>
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #766 (26d635a) into deploy/hammer (de3a5ad) will decrease coverage by 0.06%.
Report is 13 commits behind head on deploy/hammer.
The diff coverage is 14.96%.

@@                Coverage Diff                @@
##           deploy/hammer     #766      +/-   ##
=================================================
- Coverage          54.26%   54.20%   -0.06%     
=================================================
  Files                263      263              
  Lines               6583     6619      +36     
  Branches             875      886      +11     
=================================================
+ Hits                3572     3588      +16     
- Misses              2871     2891      +20     
  Partials             140      140              
Flag Coverage Δ
api-server 81.93% <48.38%> (-0.36%) ⬇️
dashboard 17.68% <4.16%> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...-server/api_server/routes/tasks/scheduled_tasks.py 75.86% <0.00%> (-2.71%) ⬇️
packages/dashboard/src/components/alert-store.tsx 0.00% <0.00%> (ø)
packages/dashboard/src/components/app-base.tsx 0.00% <0.00%> (ø)
packages/dashboard/src/components/app-events.ts 100.00% <ø> (ø)
packages/dashboard/src/components/map-app.tsx 0.00% <0.00%> (ø)
...ages/dashboard/src/components/tasks/task-alert.tsx 0.00% <0.00%> (ø)
...kages/dashboard/src/components/tasks/tasks-app.tsx 0.00% <0.00%> (ø)
...t-components/lib/beacons/beacon-table-datagrid.tsx 90.90% <ø> (ø)
...react-components/lib/doors/door-table-datagrid.tsx 74.28% <ø> (ø)
...react-components/lib/lifts/lift-table-datagrid.tsx 56.41% <ø> (ø)
... and 11 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

aaronchongth and others added 2 commits September 11, 2023 02:39
* Show month and day view

Signed-off-by: Aaron Chong <[email protected]>

* Turn off auto refresh when viewing schedule

Signed-off-by: Aaron Chong <[email protected]>

* Format date correctly to match with the frontend format

Signed-off-by: angatupyry <[email protected]>

* Auto refresh to be determined in the interval creation effect

Signed-off-by: Aaron Chong <[email protected]>

* Changing name to be explicit for panel

Signed-off-by: Aaron Chong <[email protected]>

---------

Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: angatupyry <[email protected]>
Co-authored-by: angatupyry <[email protected]>
(cherry picked from commit c885e3d)
Signed-off-by: Aaron Chong <[email protected]>
* Display an alert when low display res detected

Signed-off-by: Aaron Chong <[email protected]>

* Raising e2e test resolution

Signed-off-by: Aaron Chong <[email protected]>

* Adding comment about raising testing resolution

Signed-off-by: Aaron Chong <[email protected]>

---------

Signed-off-by: Aaron Chong <[email protected]>
(cherry picked from commit 0d352fe)
Signed-off-by: Aaron Chong <[email protected]>
@aaronchongth aaronchongth merged commit c2a158f into deploy/hammer Sep 11, 2023
@aaronchongth aaronchongth deleted the port/hammer branch September 11, 2023 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant