Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/form input required #764

Merged
merged 6 commits into from
Sep 8, 2023
+195 −152
Merged

Feature/form input required #764

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
92dbbb1
Making form fields required
aaronchongth Sep 7, 2023
4627dcf
Basic checks for each task description to allow submission
aaronchongth Sep 7, 2023
cd79d84
Fix e2e tests, select coe for patrol explicitly
aaronchongth Sep 7, 2023
dbc681b
Splitting interface and refactoring validity check
aaronchongth Sep 8, 2023
979de72
Delivery quantity to positive int field, and sku to text field, monit…
aaronchongth Sep 8, 2023
f279f67
Disable submit when clean zone is removed
aaronchongth Sep 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 31 additions & 1 deletion packages/dashboard-e2e/tests/ui-interactions/create-task-from-any-tab.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,37 @@ describe('submit task', () => {
const appBar = await getAppBar();
await (await appBar.$('button[aria-label="System Overview"]')).click();
await (await appBar.$('button[aria-label="new task"]')).click();
await (await $('#task-type')).click();
const getPatrolOption = async () => {
const options = await $$('[role=option]');
for (const opt of options) {
const text = await opt.getText();
if (text === 'Patrol') {
return opt;
}
}
return null;
};
await browser.waitUntil(async () => !!(await getPatrolOption()));
const patrolOption = (await getPatrolOption())!;
await patrolOption.click();

await (await $('#place-input')).click();
const getCoeOption = async () => {
const options = await $$('[role=option]');
for (const opt of options) {
const text = await opt.getText();
if (text === 'coe') {
return opt;
}
}
return null;
};
await browser.waitUntil(async () => !!(await getCoeOption()));
const coeOption = (await getCoeOption())!;
await coeOption.click();

await (await $('button[aria-label="Submit Now"]')).click();
await expect($('div=Successfully created task')).toBeDisplayed();
});
}).timeout(60000);
});
15 changes: 14 additions & 1 deletion packages/dashboard-e2e/tests/ui-interactions/submit-task.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,20 @@ describe('submit task', () => {
const patrolOption = (await getPatrolOption())!;
await patrolOption.click();

await (await $('#place-input')).setValue('coe');
await (await $('#place-input')).click();
const getCoeOption = async () => {
const options = await $$('[role=option]');
for (const opt of options) {
const text = await opt.getText();
if (text === 'coe') {
return opt;
}
}
return null;
};
await browser.waitUntil(async () => !!(await getCoeOption()));
const coeOption = (await getCoeOption())!;
await coeOption.click();

await (await $('button[aria-label="Submit Now"]')).click();
await expect($('div=Successfully created task')).toBeDisplayed();
Expand Down
2 changes: 1 addition & 1 deletion packages/react-components/lib/form-inputs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export function PositiveIntField({ value = 0, onChange, ...props }: PositiveIntF
{...props}
type="number"
value={valueInput}
inputProps={{ min: 0 }}
inputProps={{ min: 1 }}
onKeyDown={(ev) => {
if ('-+.'.indexOf(ev.key) >= 0) {
ev.preventDefault();
Expand Down
Loading