Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase testing #1036

Merged
merged 16 commits into from
Dec 3, 2024
Merged

Increase testing #1036

merged 16 commits into from
Dec 3, 2024

Conversation

aaronchongth
Copy link
Member

What's new

  • Correct codecov.yml
  • Increase testing

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

Signed-off-by: Aaron Chong <[email protected]>
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 86.95652% with 3 lines in your changes missing coverage. Please review.

Project coverage is 51.82%. Comparing base (dd4d953) to head (3affe31).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...mf-dashboard-framework/src/components/map/index.ts 0.00% 0 Missing and 1 partial ⚠️
...d-framework/src/components/robots/robots-table.tsx 0.00% 1 Missing ⚠️
.../rmf-dashboard-framework/src/micro-apps/map-app.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1036       +/-   ##
===========================================
+ Coverage   40.60%   51.82%   +11.21%     
===========================================
  Files         334      295       -39     
  Lines       17212    15310     -1902     
  Branches      680      772       +92     
===========================================
+ Hits         6989     7934      +945     
+ Misses      10119     7334     -2785     
+ Partials      104       42       -62     
Flag Coverage Δ
rmf-dashboard-framework 44.81% <86.95%> (+12.70%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
@aaronchongth aaronchongth force-pushed the more-tests branch 2 times, most recently from 2c4f526 to ca74d58 Compare November 27, 2024 05:18
Signed-off-by: Aaron Chong <[email protected]>
@aaronchongth aaronchongth marked this pull request as ready for review November 27, 2024 17:13
@aaronchongth
Copy link
Member Author

To keep the commits small, I'll continue with more testing on a subsequent PR

codecov.yml Outdated
- packages/rmf-dashboard-framework/examples
- "**/*.js"
- "**/*.stories.tsx"
- "**/index.ts"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

index.ts shouldn't be ignored.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that, I accidentally left that in after trying some stuff

3affe31

@@ -532,6 +533,7 @@ export const Map = styled((props: MapProps) => {
camera.updateProjectionMatrix();
}}
orthographic={true}
resize={{ polyfill: ResizeObserver }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the browser support, I don't think there is a need for us to polyfill.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, that was added only for testing, I've found a solution for that on ZeeCoder/use-resize-observer#40 (comment) to use a mock resize observer

3affe31

@aaronchongth aaronchongth requested a review from koonpeng December 2, 2024 02:49
@aaronchongth aaronchongth merged commit 1a9d593 into main Dec 3, 2024
2 checks passed
@aaronchongth aaronchongth deleted the more-tests branch December 3, 2024 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants