-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase testing #1036
Increase testing #1036
Conversation
Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1036 +/- ##
===========================================
+ Coverage 40.60% 51.82% +11.21%
===========================================
Files 334 295 -39
Lines 17212 15310 -1902
Branches 680 772 +92
===========================================
+ Hits 6989 7934 +945
+ Misses 10119 7334 -2785
+ Partials 104 42 -62
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
a0e9b78
to
dc33857
Compare
Signed-off-by: Aaron Chong <[email protected]>
dc33857
to
26d7bcf
Compare
Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
2c4f526
to
ca74d58
Compare
Signed-off-by: Aaron Chong <[email protected]>
ca74d58
to
e78909d
Compare
To keep the commits small, I'll continue with more testing on a subsequent PR |
codecov.yml
Outdated
- packages/rmf-dashboard-framework/examples | ||
- "**/*.js" | ||
- "**/*.stories.tsx" | ||
- "**/index.ts" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
index.ts
shouldn't be ignored.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching that, I accidentally left that in after trying some stuff
@@ -532,6 +533,7 @@ export const Map = styled((props: MapProps) => { | |||
camera.updateProjectionMatrix(); | |||
}} | |||
orthographic={true} | |||
resize={{ polyfill: ResizeObserver }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the browser support, I don't think there is a need for us to polyfill.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, that was added only for testing, I've found a solution for that on ZeeCoder/use-resize-observer#40 (comment) to use a mock resize observer
…ng, address comments Signed-off-by: Aaron Chong <[email protected]>
What's new
codecov.yml
Self-checks