Fix detachment #40
Merged
Fix detachment #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
luca-della-vedova
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing open-rmf/rmf_site#238 there was a bug was discovered for the
.detachfeature. The detach operation would remove theUnusedTargetcomponent from a target, but it would not put in anyInputStorage, sogive_inputwould error out when trying to give an input to the detached node. This PR updatesgive_inputto account forDetachedcorrectly. It also adds a regression test,test_detach, which would fail without the changes in this PR.In the process of fixing the above issue, I took the opportunity to add and refine a few other tests which were helpful in narrowing in on this issue. I've also introduced
InputTypeIndicatorwhich keeps track of the expected input type for any operation. This allows us to do some runtime introspection and generate more helpful error messages if input/output types ever clash.