WIP: Fix 1.75 build failure / add CI #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
|
We could definitely do better in terms of how comprehensive the test coverage is. There are so many different possible combinations of things that people can do with this library that there are nearly uncountable nooks and crannies to consider. But I've added in a unit test for the array split key limit, so at least that one is covered now. |
mxgrey
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
take_ifis only stable in Rust 1.80 so removed it inspired on its implementation in the standard library.I don't think that is really covered by tests since I had a first implementation that was wrong and it was not caught by⚠️ there.
cargo testso bigI also added a few steps to the Linux CI to install and try Rust 1.75, happy to put it in a different workflow if that is a better option