return error on empty join

Signed-off-by: Teo Koon Peng <[email protected]>
open-rmf · Jan 6, 2025 · e3e1fb7 · e3e1fb7
1 parent 6725752
commit e3e1fb7
Show file tree

Hide file tree

Showing 3 changed files with 68 additions and 1 deletion.
diff --git a/src/diagram.rs b/src/diagram.rs
@@ -431,6 +431,9 @@ pub enum DiagramError {
     #[error("response cannot be split")]
     NotSplittable,
 
+    #[error("empty join is not allowed")]
+    EmptyJoin,
+
     #[error(transparent)]
     CannotTransform(#[from] TransformError),
 

diff --git a/src/diagram/join.rs b/src/diagram/join.rs
@@ -70,7 +70,7 @@ mod tests {
     use smallvec::SmallVec;
     use test_log::test;
 
-    use crate::{diagram::testing::DiagramTestFixture, Diagram, JsonPosition};
+    use crate::{diagram::testing::DiagramTestFixture, Diagram, DiagramError, JsonPosition};
 
     #[test]
     fn test_join() {
@@ -155,4 +155,63 @@ mod tests {
         assert!(result[1] == 3 || result[1] == 6);
         assert!(result[0] != result[1]);
     }
+
+    #[test]
+    fn test_empty_join() {
+        let mut fixture = DiagramTestFixture::new();
+
+        fn get_split_value(pair: (JsonPosition, serde_json::Value)) -> serde_json::Value {
+            pair.1
+        }
+
+        fixture.registry.register_node_builder(
+            "get_split_value".to_string(),
+            "get_split_value".to_string(),
+            |builder, _config: ()| builder.create_map_block(get_split_value),
+        );
+
+        let diagram = Diagram::from_json(json!({
+            "ops": {
+                "start": {
+                    "type": "start",
+                    "next": "split",
+                },
+                "split": {
+                    "type": "split",
+                    "index": ["getSplitValue1", "getSplitValue2"]
+                },
+                "getSplitValue1": {
+                    "type": "node",
+                    "builder": "get_split_value",
+                    "next": "op1",
+                },
+                "op1": {
+                    "type": "node",
+                    "builder": "multiply3_uncloneable",
+                    "next": "terminate",
+                },
+                "getSplitValue2": {
+                    "type": "node",
+                    "builder": "get_split_value",
+                    "next": "op2",
+                },
+                "op2": {
+                    "type": "node",
+                    "builder": "multiply3_uncloneable",
+                    "next": "terminate",
+                },
+                "join": {
+                    "type": "join",
+                    "next": "terminate",
+                },
+                "terminate": {
+                    "type": "terminate",
+                },
+            }
+        }))
+        .unwrap();
+
+        let err = fixture.spawn_io_workflow(&diagram).unwrap_err();
+        assert!(matches!(err, DiagramError::EmptyJoin));
+    }
 }
diff --git a/src/diagram/workflow_builder.rs b/src/diagram/workflow_builder.rs
@@ -231,6 +231,11 @@ fn connect_vertex<'a>(
         // join needs all incoming edges to be connected at once so it is done at the vertex level
         // instead of per edge level.
         DiagramOperation::Join(_) => {
+            if target.in_edges.is_empty() {
+                if target.in_edges.is_empty() {
+                    return Err(DiagramError::EmptyJoin);
+                }
+            }
             let outputs: Vec<DynOutput> = target
                 .in_edges
                 .iter()